-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): migrate to node-fetch-native
#8157
Conversation
Correct me if I'm wrong, but we were blocked by node-fetch v3 because Jest doesn't work with ESM-only package, and with Vitest it should be fine now. Or is there more behind this? |
Oh yeah, that's a good point. We could probably just upgrade it. I am just thinking to be able to use the native fetch in Node v18 is a good thing to have. It's not a big deal and I am fine with either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think being able to use native fetch is good enough to justify this change 👍🏼
If we want to emulate node 18 native fetch, should we do |
If we are going to use the native fetch eventually, we can replace Node.js fetch uses this library underlyingly nodejs/node#41749 |
Tried Udici, sadly the fetch API is not available in v14 https://undici.nodejs.org/#/?id=undicifetchinput-init-promise |
This reverts commit 79c8fb0.
See https://github.com/unjs/node-fetch-native for reason. We were blocked by ESM only of
node-fetch
v3.